Conversation
Member
|
The mutation happens inside logger.close(), which runs on scan-done after the exit code is already decided. Nothing reads the findings afterward. |
Member
|
But I'm fine with removing the mutation |
Member
|
Merging is blocked: Commits must have verified signatures. |
Member
|
@copilot Move the version normalization that is now duplicated across 3 files to utils.ts and import it |
eoftedal
approved these changes
Sep 29, 2026
PekSec
force-pushed
the
codex/cyclonedx-compatibility
branch
from
September 30, 2026 12:46
e793fb7 to
f171f16
Compare
Author
|
Both commits now have verified signatures. No code changes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CycloneDX reporting mutated shared scan results while formatting versions and could discard vulnerabilities and evidence when the same component appeared more than once. This PR formats a report-local copy and merges repeated components' vulnerability ranges, occurrences, and detection evidence before deduplication.
The existing version transformation is preserved for XML 1.4 and JSON 1.4/1.6/1.7, including PURLs, component references, and identity evidence. This addresses the parser compatibility concern raised on #622 without changing consumer-facing formatting or introducing a new option. The original scan findings remain unchanged.
This is the reporter-only replacement for the relevant part of #622. CLI, extension, and build-script changes are excluded.
Validation: compatibility regressions first failed, then passed after the fix; all 68 Node tests, TypeScript checking, nonfixing ESLint, and repository validation pass. The full repository detection suite also passes. Tests cover short versions, releases, prereleases, build metadata, unchanged inputs, merged components, schema validation, and VEX/component reference consistency.
AI-assisted implementation. The retained legacy transformation pads short versions and replaces hyphens; it is not a new numeric-only version sanitizer.
Related independent replacements: CLI fixes #623 and browser extensions #624.